Remove unnecessary Valkyrien Skies chunkloading hack.#595
Merged
CommandrMoose merged 2 commits intoApr 2, 2026
Merged
Conversation
50ap5ud5
approved these changes
Feb 28, 2026
Member
50ap5ud5
left a comment
50ap5ud5
left a comment
There was a problem hiding this comment.
Thanks for looking into this and testing that it isn't needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been thinking about this for a while now.
In #542 I added a small hack which I hoped would fix the issue where the player sometimes falls through the ship when exiting the TARDIS. In retrospect, this hack didn't really do that at all, at best it might have reduced the probability of falling through ships slightly.
Considering that this should hopefully be fixed upstream now, I think it's best to remove this hack completely.
Since there hasn't been any official release containing the hack, I thought it was fair to remove it from the changelog as well.