chore: Github Actions CI/CD 파이프라인 구축#53
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces production-ready Docker configurations, including a new docker-compose-prod.yml with Fluent-Bit logging and PostgreSQL, and adds Spring Boot Actuator for health monitoring. Feedback was provided regarding the Docker health check interval, which was set to an impractical 24 hours, and the use of the Actuator health endpoint. Additionally, corrections were suggested for incorrect volume paths in the production compose file and a suspicious reference to Dockerfile.prev in the development configuration.
| HEALTHCHECK --interval=24h --timeout=10s --start-period=40s --retries=3 \ | ||
| CMD curl -sf http://localhost:7300/health || exit 1 |
There was a problem hiding this comment.
HEALTHCHECK의 interval이 24시간(24h)으로 설정되어 있습니다. 이는 컨테이너의 상태 변화를 감지하기에 너무 긴 시간입니다. 일반적으로 30초(30s) 또는 1분(1m) 정도로 설정하는 것이 적절합니다. 또한, Spring Boot Actuator를 의존성에 추가하셨으므로 기본 헬스체크 경로인 /actuator/health를 사용하는 것이 좋습니다.
HEALTHCHECK --interval=30s --timeout=10s --start-period=40s --retries=3 \
CMD curl -sf http://localhost:7300/actuator/health || exit 1
| - ./fluentbit/fluent-bit.conf:/fluent-bit/etc/fluent-bit.conf:ro | ||
| - ./fluentbit/parsers.conf:/fluent-bit/etc/parsers.conf:ro |
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| dockerfile: Dockerfile.prev |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 작업 내용 (Description)
🔄 변경 유형 (Type of Change)
✅ 체크리스트 (Checklist)