Allow redeployment of failed and stuck-upgrading stacks via deploy hook#349
Merged
Wiesenwischer merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
The deploy hook endpoint rejected all non-Running deployments, blocking CI pipelines from retrying after a failed deploy. Now Failed and stuck Upgrading deployments can be redeployed. Installing and Removed remain rejected. The DeploymentService recovers stuck Upgrading status via MarkAsFailed + StartRollbackProcess before proceeding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/hooks/deploy) rejected all non-Running deployments, blocking CI pipelines from retrying after a failed deploy (e.g. NuGet error in Dockerfile)Failedand stuckUpgradingdeployments can be redeployed via the hookInstallingandRemovedremain non-redeployableDeploymentServicerecovers stuckUpgradingstatus viaMarkAsFailed→StartRollbackProcessbefore proceeding with the new deploymentChanged Files
DeployViaHookCommand.cs— accept Failed/Upgrading statuses, use "retried" action labelDeploymentService.cs— add Upgrading to upgrade detection, recover stuck stateDeployViaHookHandlerTests.cs— tests for new redeployable statuses, updated rejection testsTest plan