Skip to content

Conversation

@weronika
Copy link
Contributor

@weronika weronika commented Nov 7, 2016

  • extended definition for font-family set
  • added information about styles modification for Chinese in Reference Page

https://wikia-inc.atlassian.net/browse/XW-2203

{{#wds-button class='wds-is-text wds-is-squished'}}Text{{/wds-button}}
{{/component-demo}}
<p class="warning-note">
<strong>Important note:</strong> for readablility purposes we use different styling for squished button in Global Navigation for Chinese - the font is larger and has bold applied.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...has bold applied

Don't we remove bold for Chinese?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it clear that it's temporary solution that doesn't scale. It has to be rethought when someone encounters similar issue - currently we have only one use-case and we're not 100% sure how to approach it.

Copy link
Contributor

@kvas-damian kvas-damian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments above

{{#wds-button class='wds-is-text wds-is-squished'}}Text{{/wds-button}}
{{/component-demo}}
<p class="warning-note">
<strong>Important note:</strong> for readablility purposes we use different styling for squished button in Global Navigation for Chinese - the font is larger and has bold removed.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in "readablility".

@kvas-damian kvas-damian merged commit f9cc9f4 into master Nov 14, 2016
@kvas-damian kvas-damian deleted the XW-2203 branch November 14, 2016 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants