XW-2203 | extended definition for font-family set #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvas-damian
reviewed
Nov 8, 2016
| {{#wds-button class='wds-is-text wds-is-squished'}}Text{{/wds-button}} | ||
| {{/component-demo}} | ||
| <p class="warning-note"> | ||
| <strong>Important note:</strong> for readablility purposes we use different styling for squished button in Global Navigation for Chinese - the font is larger and has bold applied. |
Contributor
There was a problem hiding this comment.
...has bold applied
Don't we remove bold for Chinese?
Contributor
There was a problem hiding this comment.
Please make it clear that it's temporary solution that doesn't scale. It has to be rethought when someone encounters similar issue - currently we have only one use-case and we're not 100% sure how to approach it.
kvas-damian
suggested changes
Nov 8, 2016
Contributor
kvas-damian
left a comment
kvas-damian
left a comment
There was a problem hiding this comment.
Please address comments above
kvas-damian
approved these changes
Nov 8, 2016
rogatty
reviewed
Nov 8, 2016
| {{#wds-button class='wds-is-text wds-is-squished'}}Text{{/wds-button}} | ||
| {{/component-demo}} | ||
| <p class="warning-note"> | ||
| <strong>Important note:</strong> for readablility purposes we use different styling for squished button in Global Navigation for Chinese - the font is larger and has bold removed. |
rogatty
approved these changes
Nov 8, 2016
kvas-damian
approved these changes
Nov 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wikia-inc.atlassian.net/browse/XW-2203