XW-1687 | static logged in global nav #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
components/_global-navigation.scss
Outdated
| &__content-bar { | ||
| border-top: $border-top-width solid $color-slate-gray; | ||
| color: $color-dark-blue-gray; | ||
| display: inline-block; |
Contributor
There was a problem hiding this comment.
I had a feeling it was needed here to make ellipsis work on longer translations.
Contributor
Author
There was a problem hiding this comment.
It works without it. At least on my Chrome.
EDIT: And on Safari and on Firefox works too.
|
LGTM |
components/_global-navigation.scss
Outdated
| text-align: center; | ||
| text-decoration: none; | ||
|
|
||
| &.wds-has-fixed-width { |
Contributor
There was a problem hiding this comment.
I believe we already removed this class ;)
added 8 commits
August 25, 2016 18:01
…d :hover selectors to match LVHA-order
components/_avatar.scss
Outdated
| .wds-avatar { | ||
| border: solid 2px currentColor; | ||
| height: 28px; | ||
| width: 28px; |
Contributor
There was a problem hiding this comment.
Sizes for squares could be extracted into a variable or a mixin.
Contributor
|
lgtm |
components/_dropdowns.scss
Outdated
| display: none; | ||
| left: 0; | ||
| position: absolute; | ||
| top: calc(100% + 1px); |
Contributor
There was a problem hiding this comment.
Why is it 1px? Is it related to border?
Contributor
Author
There was a problem hiding this comment.
Yup, bottom nav "border".
Contributor
There was a problem hiding this comment.
isn't nav specific style?
I'm not sure if it should be part of dropdown component.
kvas-damian
pushed a commit
that referenced
this pull request
Sep 2, 2016
DAT-4613 | remove bower in-repo dependencies + simplify build process + prepare env for gulp link
hakubo
pushed a commit
that referenced
this pull request
Dec 12, 2018
IRIS-4101 Followup: pulling translations and adding new label for old notification icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wikia-inc.atlassian.net/browse/XW-1687
Wikia/design-system-reference-page#63
@Wikia/x-wing