fix(ci): prevent JS syntax error when workflow dispatch inputs contain special characters

[Wikid82]

Summary

Fixes a SyntaxError: Unexpected identifier 't' that aborted the weekly nightly promotion workflow when manually triggered with a reason containing an apostrophe (e.g. "didn't run as scheduled").

Root Cause

GitHub Actions substitutes ${{ }} expressions before the JavaScript source is parsed. User-controlled and job-output values were interpolated directly into single-quoted JS string literals inside github-script steps. Any apostrophe in those values terminated the string early, causing a parse error that killed the entire job.

Fix

All affected values are moved to the step-level env: block and read via process.env.* in the script body. Values are delivered as runtime environment variables and never evaluated as JavaScript source code.

Three injection points secured:

• inputs.skip_workflow_check — check-nightly-health job
• inputs.reason — create-promotion-pr job, Create Promotion PR step
• needs.check-nightly-health.outputs.failure_reason + .latest_run_url — notify-on-failure job, Create Failure Issue step

Validation

• yamllint: ✅ no errors
• actionlint: ✅ no errors
• Full expression audit: zero remaining user-controlled inputs.* values in JS string literals
• Supervisor reviewed: ✅ APPROVED
• QA Security audit: ✅ PASS

Testing

Manual test plan: docs/issues/issue-1022-manual-test-plan.md

To verify: manually trigger weekly-nightly-promotion.yml with reason "didn't run as scheduled" — the job should complete without a SyntaxError.

Fixes #1022

[Copilot]

Pull request overview

This PR hardens the weekly nightly promotion workflow against JavaScript parse failures caused by special characters in workflow dispatch inputs.

Changes:

• Moves affected workflow values into step-level environment variables before reading them in github-script.
• Adds/updates QA and planning documentation for issue #1022.
• Adds a manual validation plan for the workflow dispatch regression.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
.github/workflows/weekly-nightly-promotion.yml	Passes dispatch inputs and dynamic outputs through env before JavaScript use.
docs/issues/issue-1022-manual-test-plan.md	Adds manual regression scenarios for special-character dispatch reasons.
docs/plans/current_spec.md	Replaces the active spec with the issue #1022 workflow injection plan.
docs/reports/qa_report.md	Replaces the QA report with the final audit for this workflow fix.
docs/reports/qa_report_2026-05-19_issue1022.md	Adds an earlier audit report for issue #1022.

[github-advanced-security]

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

• The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
• Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
• You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

[github-actions]

✅ Supply Chain Verification Results

✅ PASSED

📦 SBOM Summary

• Components: 1487

🔍 Vulnerability Scan

Severity	Count
🔴 Critical	0
🟠 High	0
🟡 Medium	4
🟢 Low	2
Total	6

📎 Artifacts

• SBOM (CycloneDX JSON) and Grype results available in workflow artifacts

---

_{Generated by Supply Chain Verification workflow • View Details}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!