fix(ci): improve Playwright installation steps by removing redundant system dependency installs and enhancing exit code handling#655
Merged
Conversation
…system dependency installs and enhancing exit code handling
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the Playwright browser installation process in the E2E test workflow by removing redundant system dependency installation steps and enhancing exit code handling. The PR addresses debugging issues identified during E2E CI browser installation.
Changes:
- Removed redundant
npx playwright install-depscommands that were unnecessary sincenpx playwright install --with-depsalready installs system dependencies - Fixed exit code handling by capturing the installation command's exit status in a variable before subsequent commands
- Added explicit
exit $EXIT_CODEto ensure installation failures properly propagate and fail the workflow step
Contributor
❌ E2E Test Results: FAILED (Split Browser Jobs)Some browser tests failed. Each browser runs independently. Browser Results (Sequential Execution)
Phase 1 Hotfix Active: Each browser runs in a separate job. One browser failure does not block others. 📊 View workflow run & download reports 🤖 Phase 1 Emergency Hotfix - See docs/plans/browser_alignment_triage.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debugging e2e testing CI browser installing