Skip to content

fix(ci): improve Playwright installation steps by removing redundant system dependency installs and enhancing exit code handling#655

Merged
Wikid82 merged 2 commits intomainfrom
hotfix/ci
Feb 4, 2026
Merged

fix(ci): improve Playwright installation steps by removing redundant system dependency installs and enhancing exit code handling#655
Wikid82 merged 2 commits intomainfrom
hotfix/ci

Conversation

@Wikid82
Copy link
Owner

@Wikid82 Wikid82 commented Feb 4, 2026

debugging e2e testing CI browser installing

…system dependency installs and enhancing exit code handling
Copilot AI review requested due to automatic review settings February 4, 2026 17:45
@Wikid82 Wikid82 merged commit 835700b into main Feb 4, 2026
1 check passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request improves the Playwright browser installation process in the E2E test workflow by removing redundant system dependency installation steps and enhancing exit code handling. The PR addresses debugging issues identified during E2E CI browser installation.

Changes:

  • Removed redundant npx playwright install-deps commands that were unnecessary since npx playwright install --with-deps already installs system dependencies
  • Fixed exit code handling by capturing the installation command's exit status in a variable before subsequent commands
  • Added explicit exit $EXIT_CODE to ensure installation failures properly propagate and fail the workflow step

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

❌ E2E Test Results: FAILED (Split Browser Jobs)

Some browser tests failed. Each browser runs independently.

Browser Results (Sequential Execution)

Browser Status Shards Execution
Chromium ⚠️ cancelled 1 Sequential
Firefox ⚠️ cancelled 1 Sequential
WebKit ⚠️ cancelled 1 Sequential

Phase 1 Hotfix Active: Each browser runs in a separate job. One browser failure does not block others.

📊 View workflow run & download reports


🤖 Phase 1 Emergency Hotfix - See docs/plans/browser_alignment_triage.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants