Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug (issue #96) where the ignore and maxdepth parameters for category filters were not being read from template parameters. These checks were accidentally removed in a prior commit (0ea41414), causing the category ignore functionality to be completely non-functional. The fix re-adds the parameter parsing in CatFilter.make() and bumps the version to 1.1.2.
Changes:
- Re-added parsing of
ignoreandmaxdepthtemplate parameters inCatFilter.make()so they are passed through to theCatFilterconstructor. - Bumped the project version from
1.1.1to1.1.2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ukbot/filters.py |
Re-adds reading of ignore (comma-separated list appended to the ignore list) and maxdepth (integer override) template parameters in CatFilter.make() |
pyproject.toml |
Version bump from 1.1.1 to 1.1.2 to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-add the checks for category ignore and maxdepth in filters.py, which were removed in 0ea4141 (presumably by accident).
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #96
Tested?
Added to documentation?
[optional] Are there any pre- or post-deployment tasks we need to perform?