T239598 : Allow users to customise data granularity for edits over time graph

[sanyam-git]

with reference to T239598
work don :

• at first the user will be displayed the default view (best suitable).
• then the user can change the display as per his requirements.
• the AJAX request for another display is sent when user clicks the button

[sanyam-git]

with reference to T207846 : Encode 4-byte unicode properly.
added 'charset' : 'utf8mb4' in database settings in settings/base.py

[Samwalton9]

Thanks! Can you split these tasks out into two different pull requests please?

[sanyam-git]

@Samwalton9 , moved the task T207846 : Encode 4-byte unicode properly to another pull request. Thanks

[Samwalton9]

Looking good! I just have one question about some code that I didn't entirely understand :)

[Jain-Aditya]

At this point, it looks like this and the daily and yearly charts doesn't show up.

Your changes were fine 2 commits behind where I left my previous comment. You just had to remove the line numbers I mentioned.

[sanyam-git]

At this point, it looks like this and the daily and yearly charts doesn't show up.

Your changes were fine 2 commits behind where I left my previous comment. You just had to remove the line numbers I mentioned.

I was getting the same display, just hard refresh the page to load the latest javascript changes and the display will be fine.

[Jain-Aditya]

At this point, it looks like this and the daily and yearly charts doesn't show up.

Your changes were fine 2 commits behind where I left my previous comment. You just had to remove the line numbers I mentioned.

I was getting the same display, just hard refresh the page and to load the latest javascript changes.

Yup, working fine!

[Jain-Aditya]

Overall it is looking good! Also could you please modify the CSV download view as per the graphs? Currently it gives edits per day irrespective of the view type.

[sanyam-git]

@Jain-Aditya I have added the CSV functionality and also added tests for the same.
The checks for my first and second commit looks failed maybe because I committed the remaining changes after them. Next time I will club all the changes in one commit.
But as I see all the changes are checked/passed in the last commit.
I think it is good to go. :)

[Jain-Aditya]

Thanks! I see there is lot of code repeated in the time_csv view and time_statistics_data view. What you could do here is internally call an API in the csv view by passing view_type parameter(You can use requests library) and then create a CSV out of it. This will reduce a lot of lines of code. Could you try that?

[sanyam-git]

Great idea ! I will try to implement it. Thanks.

[sanyam-git]

Implemented the code refactor.

[Jain-Aditya]

Just a small change and it will be good to go. CSV header should also be changed to month, date and year accordingly.

[sanyam-git]

done 👍

[Jain-Aditya]

Looking good! thanks @sanyam-git for your valuable work on this task.