chore: willboosterify this repo#146
Merged
WillBooster-bot merged 1 commit intomainfrom May 8, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the @willbooster/wb dependency to version 13.12.14, adds @types/* to the preapproved npm packages in .yarnrc.yml, and modifies the oxlint configuration. Feedback was provided regarding the oxlint.config.ts file, where an intermediate variable was introduced unnecessarily; it is recommended to import the configuration directly to eliminate redundancy.
Comment on lines
+2
to
+4
| import oxlintBaseConfig from '@willbooster/oxlint-config'; | ||
|
|
||
| const oxlintResolvedConfig = oxlintBaseConfig; |
There was a problem hiding this comment.
The intermediate variable oxlintBaseConfig and its assignment to oxlintResolvedConfig are redundant. The configuration can be imported directly as oxlintResolvedConfig to simplify the code, adhering to the repository style guide rule regarding the elimination of redundancy.
Suggested change
| import oxlintBaseConfig from '@willbooster/oxlint-config'; | |
| const oxlintResolvedConfig = oxlintBaseConfig; | |
| import oxlintResolvedConfig from '@willbooster/oxlint-config'; |
References
- Simplify code as much as possible to eliminate redundancy. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.