chore: willboosterify this repo#8
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a newline to the README and removes the typescript dependency from package.json. A critical issue was identified regarding the removal of typescript, as it is required by build tools like tsup to generate type declarations and handle configuration, which will likely lead to build failures.
| "sort-package-json": "3.6.1", | ||
| "tsup": "8.5.0", | ||
| "typescript": "5.9.3", | ||
| "vitest": "4.1.4" |
There was a problem hiding this comment.
Removing typescript from devDependencies is likely to cause issues with the build and development workflow. While the typecheck script has been updated to use tsgo, other tools in the project like tsup and next typically depend on the presence of the typescript package (e.g., for generating type declarations or processing tsconfig.json). Since the package defines a types output in its exports, tsup will likely fail to produce the required .d.ts files without typescript installed.
"typescript": "5.9.3",
"vitest": "4.1.4"
1 participant
No description provided.