fix: avoid typeless config warnings in wbfy#724
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
There was a problem hiding this comment.
Code Review
This pull request migrates the generated configuration files for oxfmt and oxlint from ESM to CommonJS to improve auto-discovery and avoid Node.js ESM warnings. It also updates the generation logic to concurrently handle the removal of legacy files and the creation of new configurations. Feedback focuses on improving efficiency by avoiding redundant file writes when configurations already exist or do not require migration, and replacing synchronous file system calls with asynchronous ones to prevent blocking the event loop.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates .gitignore files to ignore the .wb/ directory and removes redundant verify-code scripts across multiple packages. It refactors Docker build optimization logic by removing the optimizeDockerInstallPrepareScript and introduces a shared utility for generating tool configurations. Feedback suggests consolidating the duplicated normalizeContent function and using the isEsmPackage property for better consistency with the existing codebase.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates project configurations and build optimization logic across several packages. It adds .wb/ to .gitignore files, removes verify-code scripts, and simplifies Docker build optimization by removing the docker/install/prepare script. Furthermore, it refactors the generation of oxfmt and oxlint configurations into a shared utility that handles both ESM and CommonJS formats to avoid Node.js warnings. I have no feedback to provide.
Summary
oxlint ./oxfmt .auto-discovery by continuing to generate*.config.ts.wb/ignores and removal of deprecatedverify-code*scriptsWhy
*.config.ts, but not*.config.mts, so.mtscannot satisfy the no--ccommand requirement..tsconfigs trigger Node'sMODULE_TYPELESS_PACKAGE_JSONwarning."type": "module"must still receive ESM config content because CommonJSrequireis unavailable there.Testing
yarn start /Users/exkazuu/ghq/github.com/WillBooster/sharedfrompackages/wbfy.yarn start /Users/exkazuu/ghq/github.com/WillBooster/understandability-surveyfrompackages/wbfy.yarn check-for-aiinshared.yarn check-for-aiinunderstandability-survey.NODE_OPTIONS="--trace-warnings" yarn oxlint --no-error-on-unmatched-pattern .inunderstandability-survey.Notes
sharedstill has pre-existing@willbooster/wbfyunicorn/no-nullwarnings intest/packageJsonGenerator.test.ts.understandability-surveystill prints Prisma's package.json config deprecation warning duringcheck-for-ai; oxlint finishes cleanly.