Skip to content

fix: avoid typeless config warnings in wbfy#724

Merged
exKAZUu merged 8 commits intomainfrom
fix/wbfy-mts-configs
Apr 29, 2026
Merged

fix: avoid typeless config warnings in wbfy#724
exKAZUu merged 8 commits intomainfrom
fix/wbfy-mts-configs

Conversation

@exKAZUu
Copy link
Copy Markdown
Member

@exKAZUu exKAZUu commented Apr 29, 2026

Summary

  • update wbfy-generated oxlint and oxfmt config content so typeless/CommonJS packages avoid Node's typeless ESM reparsing warning while module packages keep ESM config files
  • keep no-flag oxlint . / oxfmt . auto-discovery by continuing to generate *.config.ts
  • avoid redundant generated config writes by reading existing files asynchronously and only writing when content changes
  • apply current wbfy output to this repository, including .wb/ ignores and removal of deprecated verify-code* scripts

Why

  • Current oxlint/oxfmt auto-discover *.config.ts, but not *.config.mts, so .mts cannot satisfy the no--c command requirement.
  • Typeless packages using ESM syntax in .ts configs trigger Node's MODULE_TYPELESS_PACKAGE_JSON warning.
  • Packages with "type": "module" must still receive ESM config content because CommonJS require is unavailable there.

Testing

  • Ran yarn start /Users/exkazuu/ghq/github.com/WillBooster/shared from packages/wbfy.
  • Ran yarn start /Users/exkazuu/ghq/github.com/WillBooster/understandability-survey from packages/wbfy.
  • Ran yarn check-for-ai in shared.
  • Ran yarn check-for-ai in understandability-survey.
  • Ran NODE_OPTIONS="--trace-warnings" yarn oxlint --no-error-on-unmatched-pattern . in understandability-survey.
  • Verified PR CI passes.

Notes

  • shared still has pre-existing @willbooster/wbfy unicorn/no-null warnings in test/packageJsonGenerator.test.ts.
  • understandability-survey still prints Prisma's package.json config deprecation warning during check-for-ai; oxlint finishes cleanly.

Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the generated configuration files for oxfmt and oxlint from ESM to CommonJS to improve auto-discovery and avoid Node.js ESM warnings. It also updates the generation logic to concurrently handle the removal of legacy files and the creation of new configurations. Feedback focuses on improving efficiency by avoiding redundant file writes when configurations already exist or do not require migration, and replacing synchronous file system calls with asynchronous ones to prevent blocking the event loop.

Comment thread packages/wbfy/src/generators/oxfmtConfig.ts Outdated
Comment thread packages/wbfy/src/generators/oxlintConfig.ts Outdated
Comment thread packages/wbfy/src/generators/oxlintConfig.ts Outdated
exKAZUu and others added 6 commits April 29, 2026 17:20
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu
Copy link
Copy Markdown
Member Author

exKAZUu commented Apr 29, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates .gitignore files to ignore the .wb/ directory and removes redundant verify-code scripts across multiple packages. It refactors Docker build optimization logic by removing the optimizeDockerInstallPrepareScript and introduces a shared utility for generating tool configurations. Feedback suggests consolidating the duplicated normalizeContent function and using the isEsmPackage property for better consistency with the existing codebase.

Comment thread packages/wbfy/src/generators/oxfmtConfig.ts Outdated
Comment thread packages/wbfy/src/generators/toolConfigContent.ts Outdated
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu
Copy link
Copy Markdown
Member Author

exKAZUu commented Apr 29, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project configurations and build optimization logic across several packages. It adds .wb/ to .gitignore files, removes verify-code scripts, and simplifies Docker build optimization by removing the docker/install/prepare script. Furthermore, it refactors the generation of oxfmt and oxlint configurations into a shared utility that handles both ESM and CommonJS formats to avoid Node.js warnings. I have no feedback to provide.

@exKAZUu exKAZUu merged commit e85d0b0 into main Apr 29, 2026
6 checks passed
@exKAZUu exKAZUu deleted the fix/wbfy-mts-configs branch April 29, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant