Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the linting and formatting logic to separate commands into distinct linter and formatter categories, allowing for more granular control over execution. It introduces the LintRunCommand interface and helper functions like runLintCommands to streamline command execution. Feedback was provided to merge redundant loops when populating command lists for different project types and to consolidate multiple iterations over project descendants into a single loop to improve maintainability and reduce code redundancy.
… loop Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the linting and formatting logic to separate these concerns into distinct command sets. It introduces LintRunCommand and runLintCommands to handle parallel execution of formatters and linters independently, and splits language-specific commands (Poetry, Dart) into separate lint and format functions. In packages/wb/src/commands/lint.ts, there is an opportunity to merge consecutive shouldRunLinters blocks to reduce redundancy and improve readability.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the linting and formatting logic to separate these concerns, introducing distinct commands for each and improving the execution flow. The changes include splitting buildPoetryCommand and buildDartCommand into separate lint and format functions, and updating the lint command to handle formatters and linters independently. Feedback was provided to simplify boolean logic and redundant type conversions for better readability.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the linting and formatting logic within the wb package by separating the generation and execution of formatter and linter commands. Key changes include splitting the Poetry and Dart command builders into distinct format and lint functions, and updating the lint command to execute formatters before linters with an early exit if formatting fails. Additionally, the verifyCode command was simplified by consolidating formatting and lint-fixing into a single cleanup step. I have no feedback to provide.
Summary
wb lint --formatschedule formatter commands without normal lint checkswb lint --fix --formatas cleanup mode by running formatters first, then lint fixerswb verifyto call the combined cleanup path once instead of separate format and lint-fix passesWhy
wb verify --fullpreviously ran plainoxlintduring the format pass, then ranoxlint --fixduring lint-fixwb lint,wb lint --format, andwb lint --fix --formatbehavior predictable while preserving existing cleanup workflowsTesting
yarn verifyyarn workspace @willbooster/wb typecheckyarn workspace @willbooster/wb testyarn workspace @willbooster/wb start --working-dir "$PWD" verify --full --dry-run --verboseReview