Skip to content

fix: run wb through package manager in playwright web server#742

Merged
exKAZUu merged 3 commits intomainfrom
fix-wbfy-playwright-webserver-command
May 2, 2026
Merged

fix: run wb through package manager in playwright web server#742
exKAZUu merged 3 commits intomainfrom
fix-wbfy-playwright-webserver-command

Conversation

@exKAZUu
Copy link
Copy Markdown
Member

@exKAZUu exKAZUu commented May 2, 2026

Summary

  • Generate Playwright webServer.command through the target package manager, e.g. yarn wb start --mode test or bun wb start --mode test.
  • Update generated agent instructions to recommend the same package-manager-aware command.
  • Share package-manager command detection via src/utils/packageCapabilities.ts.
  • Update the related agent-instruction test expectation for Bun projects.

Why

  • Target repositories install wb as a package dependency, so invoking wb directly can fail when the package binary directory is not on PATH.
  • The generated command should still match the target repository package manager instead of hardcoding Yarn for Bun projects.

Testing

  • yarn verify
  • yarn vitest test/agentInstructions.test.ts

Notes

  • yarn verify still reports 4 pre-existing Oxlint warnings unrelated to this change.

Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Playwright configuration and agent instructions to invoke the wb command using yarn. The review feedback suggests using a dynamic packageManager variable instead of hardcoding yarn to support different package managers like Bun, and provides a suggestion to update the test suite to reflect this change.

Comment thread packages/wbfy/src/generators/agents.ts Outdated
Comment thread packages/wbfy/test/agentInstructions.test.ts Outdated
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu
Copy link
Copy Markdown
Member Author

exKAZUu commented May 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Playwright configuration and agent instructions to ensure the wb command is executed via the project's package manager (bun or yarn). Feedback focuses on reducing code duplication by extracting the command string generation into a helper function and moving the package manager detection logic to a shared utility file to adhere to the DRY principle.

Comment thread packages/wbfy/src/fixers/playwrightConfig.ts Outdated
Comment thread packages/wbfy/src/fixers/playwrightConfig.ts Outdated
Comment thread packages/wbfy/src/fixers/playwrightConfig.ts Outdated
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu
Copy link
Copy Markdown
Member Author

exKAZUu commented May 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request centralizes the logic for determining the package manager command (bun or yarn) by introducing a getPackageManagerCommand utility. It refactors the Playwright configuration fixer and agent instruction generator to invoke wb commands through the appropriate package manager, ensuring consistency across different project environments. I have no feedback to provide as there were no review comments to evaluate.

@exKAZUu exKAZUu changed the title fix: run wb through yarn in playwright web server fix: run wb through package manager in playwright web server May 2, 2026
@exKAZUu exKAZUu merged commit 00c940a into main May 2, 2026
7 checks passed
@exKAZUu exKAZUu deleted the fix-wbfy-playwright-webserver-command branch May 2, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant