Skip to content

fix: add task dependency for plainJavadocJar (Gradle 9.x compat)#6

Merged
WilliamAGH merged 1 commit into
mainfrom
dev
Jan 15, 2026
Merged

fix: add task dependency for plainJavadocJar (Gradle 9.x compat)#6
WilliamAGH merged 1 commit into
mainfrom
dev

Conversation

@WilliamAGH
Copy link
Copy Markdown
Owner

No description provided.

@WilliamAGH WilliamAGH self-assigned this Jan 15, 2026
Copilot AI review requested due to automatic review settings January 15, 2026 08:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 15, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Improved build system compatibility with Gradle 9.x to ensure proper Maven publishing workflow.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The pull request adds a task dependency configuration to build.gradle.kts, ensuring the Javadoc JAR generation completes before Maven metadata file generation. This resolves a compatibility issue with Gradle 9.x and the vanniktech plugin by enforcing a specific build task ordering.

Changes

Cohort / File(s) Summary
Gradle Build Configuration
build.gradle.kts
Added task dependency: generateMetadataFileForMavenPublication now depends on plainJavadocJar, ensuring Javadoc JAR is generated first. This fixes Gradle 9.x compatibility with the vanniktech plugin.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🏗️ A task must wait its turn in line,
Javadoc first, then metadata so fine,
Gradle Nine finds harmony,
Build order flows in symphony! 📚✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36c7f1a and ce7d3b0.

📒 Files selected for processing (1)
  • build.gradle.kts

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@WilliamAGH WilliamAGH merged commit 0c6bbc7 into main Jan 15, 2026
1 of 2 checks passed
WilliamAGH added a commit that referenced this pull request Jan 15, 2026
fix: add task dependency for plainJavadocJar (Gradle 9.x compat)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants