Remove nokogiri dependency #77
Conversation
…ries This allows the code to be used in an app that's using Savon 2.x
Conflicts: winrm.gemspec
lib/winrm/winrm_service.rb code
Conflicts: README.md Rakefile lib/winrm/winrm_service.rb spec/config-example.yml spec/nori_type_casting_spec.rb winrm.gemspec
Replaced usages of Nokogiri with Rexml. While slower, its not noticable since the cost is really the remote WinRM calls anyway.
|
Closing, will be part of the 1.3 release. |
|
I'm not sure this is a good idea. REXML is part of the Ruby standard library, but it's also very slow so most projects don't use it. According to a (very outdated) xml benchmark:
Nokogiri has a reputation of being a bit annoying to install, but it's also very commonly used. According to RubyToolbox:
That probably includes the most popular projects that depend on WinRM, including Vagrant. This is why projects like Nori are pluggable. It prefers Nokogiri but will use REXML if it's unavailable. Similarly, there's MultiXML (inspired by MultiJSON) which helps you choose the fastest available XML library. Unfortunately I think MultiXML only supports parsing XML, not building it. |
WIP - DO NOT MERGE!
Seeing what the WinRM library would look like without a Nokogiri dependency. All integration tests pass, however there's still TODOs left around the unhappy path.