Avoid wrapping attribute values for known types #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an attribute has known type, we should return the value without wrapping it. It happens that when parsing the minSdkVersion attribute (<uses-sdk />) of the package `com.xunmeng.pinduoduo`, the condition `i == idAttribute` is valid, which causes invalid return value of `getAttrValue`. This commit fix the issue JingMatrix/LSPatch#24
JingMatrix
added a commit
to JingMatrix/LSPatch
that referenced
this pull request
Jan 18, 2025
Close #24 as fixed, which is explained in WindySha/ManifestEditor#23.
Contributor
Author
|
@WindySha Could you please have a look and merge this? |
Owner
|
Thanks. @JingMatrix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an attribute has known type, we should return the value without wrapping it. It happens that when parsing the minSdkVersion attribute () of the package
com.xunmeng.pinduoduo, the conditioni == idAttributeis valid, which causes invalid return value ofgetAttrValue. This commit fix the issue JingMatrix/LSPatch#24