Add Django 5.2 support#333
Merged
mofr merged 2 commits intoWinterFramework:masterfrom Apr 28, 2026
Merged
Conversation
nekitmish
changed the title
nekitmish
force-pushed
the
AB-1532378
branch
2 times, most recently
from
226002b to
cf91d9c
Compare
Contributor
Author
|
Sorry about the force pushes. I tested Claude automation and it went a bit crazy :\ |
mofr
requested changes
Apr 28, 2026
| with caplog.at_level(logging.WARNING): | ||
| register_route_parameters_inspector(PathParametersInspector()) | ||
| assert 'PathParametersInspector already registered' in caplog.text | ||
| _route_parameters_inspectors.pop() |
Collaborator
There was a problem hiding this comment.
It doesn't seem correct:
- protected member usage
- Why we need to pop it? It shouldn't be added in the first place
Collaborator
There was a problem hiding this comment.
The return seem to be missing here
- Widen Django constraint from >=4.2,<5 to >=4.2,<6 - Add Django 5.2 to CI test matrix - Add Django 5 classifier - Remove deprecated default_app_config (removed in Django 5.0) - Bump pytest to >=8,<9 and pytest-django to >=4.6,<5 (fix anyio/pytest incompatibility) - Remove obsolete pytest-pythonpath (built into pytest 7+) - Fix test pollution in test_route_parameter_inspector (duplicate inspector not cleaned up)
mofr
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>=4.2,<5to>=4.2,<6Framework :: Django :: 5classifierdefault_app_configfromtests/__init__.py(removed in Django 5.0)Test plan