fix: unminimize Ghostty window before raising on focus

[Wirasm]

Summary

After the Core Graphics migration (#286), kild focus could not restore a window previously minimized via kild hide. The AX API focus path only raised the window without unsetting kAXMinimizedAttribute, so hidden windows stayed in the Dock.

Root Cause

focus_window() in macos.rs called ax_perform_raise() which only sets AXRaised/AXMain attributes — neither undoes minimize. The is_minimized field was tracked in NativeWindowInfo but never checked or acted upon in the focus path.

Changes

File	Change
crates/kild-core/src/terminal/native/macos.rs	Add UnminimizeAndRaise variant to WindowAction enum
crates/kild-core/src/terminal/native/macos.rs	Add ax_unminimize_and_raise_window() function
crates/kild-core/src/terminal/native/macos.rs	Check is_minimized in focus_window() and unminimize before raising
crates/kild-core/src/terminal/native/macos.rs	Add test for new WindowAction variant

Testing

• cargo fmt --check passes
• cargo clippy --all -- -D warnings passes
• cargo test --all passes
• Manual: kild hide branch → kild focus branch restores window from Dock

Validation

cargo fmt --check && cargo clippy --all -- -D warnings && cargo test --all

Issue

Fixes #289

Implementation Details

Implementation followed artifact:

.claude/PRPs/issues/issue-289.md

Deviations from plan:

None

[Wirasm]

Automated Code Review

Summary

The fix correctly implements the unminimize-before-raise sequence for Ghostty windows. Code follows established codebase patterns with proper AX API memory management.

Strengths

• Root cause directly addressed: focus_window() now checks is_minimized and calls ax_unminimize_and_raise_window() before raising
• ax_unminimize_and_raise_window() follows exact same structure as ax_raise_window() and ax_minimize_window()
• Memory management correct: AXUIElement Create Rule ownership, proper CFRelease
• Structured logging added for the new unminimize code path
• Existing fallback to activate_app() preserved when AX fails

Suggestions (non-blocking)

• Test could use exhaustive match pattern instead of array length check for stronger compile-time verification
• Optional: Add specific log event when unminimize fails vs general AX failure (currently uses same fallback warning)

Security

• No security concerns — reuses existing AX API patterns, no new input handling or external operations

Checklist

• Fix addresses root cause from investigation
• Code follows codebase patterns
• Tests cover the change (compile-time variant check; integration tests require running Ghostty)
• No obvious bugs introduced

---

Self-reviewed