fix: open --no-agent sets agent to 'shell' instead of inheriting session agent#344
Merged
Conversation
Owner
Author
Automated Code ReviewSummaryClean, minimal fix that correctly addresses the root cause. No issues found. FindingsStrengths
Security
Checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
kild open --no-agentis used on a kild originally created with an agent (e.g.,claude), the spawn record'sagentfield showed the session's original agent name instead of"shell". This caused incorrect display inkild list,kild status, and JSON output, though the actual command (/bin/zsh) ran correctly.Root Cause
The
BareShellmatch arm inopen_sessionusedsession.agent.clone()(the session's original agent) instead of the literal"shell"thatcreate_sessioncorrectly uses.Changes
crates/kild-core/src/sessions/handler.rs"shell".to_string()matchingcreate_sessionpatternTesting
cargo fmt --checkpassescargo clippy --all -- -D warningspassescargo test --allpasses (all 874 tests)Validation
Issue
Fixes #288