refactor: remove dead code from TerminalError enum#372
Merged
Conversation
Remove unused PtyRead and ChannelSend variants, the unused impl block (error_code, is_user_error), and #[allow(dead_code)] attributes. These were left over from before the terminal rendering was wired up.
Owner
Author
PR Review SummaryCritical Issues (0 found)None. Important Issues (0 found)None. Suggestions (0 found)None. Strengths
Validation
VerdictREADY TO MERGE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PtyReadandChannelSendvariants fromTerminalErrorimpl TerminalErrorblock (error_code(),is_user_error())#[allow(dead_code)]attributes that were masking genuinely dead codeThese were left over from before terminal rendering was wired up in #349. All 7 actively-used variants are preserved.
Closes #335