refactor: move MergeReadiness to kild-core#373
Merged
Conversation
Move merge readiness business logic from CLI layer (stats.rs) into kild-core so both CLI and kild-ui can import it without duplication. - Add MergeReadiness enum to kild-core/src/git/types.rs - Add compute_merge_readiness() to kild-core/src/git/operations.rs - Export via git/mod.rs and lib.rs - Update CLI to import from kild-core - Move 11 unit tests to kild-core Closes #330
Move computation logic from free function to MergeReadiness::compute() for better type encapsulation. Remove backward-compat wrapper per project guidelines. Add edge-case tests for CI Pending/Unknown states and Draft PR handling.
Owner
Author
PR Review SummaryCritical Issues (0 found)None. Important Issues (2 found — both addressed)
Suggestions (3 found — all addressed)
Strengths
Documentation Updates
VerdictREADY TO MERGE All checks pass: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MergeReadinessenum andcompute_merge_readiness()from CLI layer (stats.rs) intokild-coreso both CLI and kild-ui can reuse merge readiness logicCloses #330