feat: add mouse selection and copy/paste to embedded terminal#374
Merged
Conversation
Wire GPUI mouse events to alacritty_terminal's Selection API for click-drag text selection with visual highlight. Cmd+C copies selection to clipboard (falls back to SIGINT with no selection), Cmd+V pastes clipboard to PTY. Supports single-click, double-click (word), and triple-click (line) selection.
Owner
Author
PR Review SummaryCritical Issues (0 found)None. Important Issues (3 found — all addressed)
Suggestions (4 found — triaged, not actioned)
Strengths
VerdictREADY TO MERGE after pushing the 3 fixes above. |
- Surface PTY write failures to user via error banner (Cmd+C/Cmd+V) - Add bounds clamping in pixel_to_grid to prevent overflow on cast - Add debug logging when selection coordinates are clamped - Fix inaccurate comments (mouse down handler, Cmd+C behavior)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #313
Test plan