feat: add shell completion support (bash, zsh, fish)#378
Merged
Conversation
Owner
Author
PR Review SummaryCritical Issues (1 found)
Suggestions (2 found)
Strengths
Documentation Updates
VerdictNEEDS FIX — One stdout flush issue to address before merge. Recommended Actions
|
Add `kild completions <shell>` that generates shell completion scripts for bash, zsh, fish, powershell, and elvish using clap_complete. Completions are generated dynamically from the clap CLI definition so they stay in sync as commands change. Closes #89
3d1f694 to
9c3f787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kild completions <shell>subcommand that generates shell tab-completion scripts usingclap_completeUsage
Test plan
cargo fmt --checkpassescargo clippy --all -- -D warningspassescargo test --allpasses (all 162 tests)cargo build --allsucceedskild completions bashoutputs valid bash completion scriptkild completions zshoutputs valid zsh completion scriptkild completions fishoutputs valid fish completion scriptkild completions(no arg) errors with usage hintkild completions invaliderrors with valid shell optionsCloses #89