refactor: extract applescript_escape into shared escape module#379
Merged
Conversation
Move applescript_escape from terminal::common::escape to a top-level escape module in kild-core. This eliminates the cross-domain dependency where notify reached into terminal internals for a general-purpose string escaping function. Also fix pre-existing unused imports in git/health.rs exposed by cargo fmt (moved test-only imports into #[cfg(test)] module). Closes #327
Owner
Author
PR Review SummaryCritical Issues (0 found)None. Important Issues (0 found)None. Suggestions (2 found)
Strengths
Documentation UpdatesNone required — no docs reference the old module path. VerdictREADY TO MERGE All 4 review agents passed. The two suggestions are minor test coverage improvements (not blockers). Reviewed by: code-reviewer, docs-impact-agent, pr-test-analyzer, silent-failure-hunter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applescript_escapefromterminal::common::escapeto a new top-levelescapemodule in kild-corenotifyreached intoterminalinternals for a general-purpose string escaping functiongit/health.rsexposed bycargo fmtCloses #327
Test plan
cargo fmt --checkpassescargo clippy --all -- -D warningspassescargo test --allpasses (803 tests)cargo build --allsucceeds