fix: render wide characters (CJK/emoji) at double cell width in terminal#383
Merged
Conversation
Break text runs at wide character boundaries so each wide char is positioned individually at its exact grid column. This prevents width errors from accumulating across mixed normal/wide character runs. Also extend the focused cursor to span 2 cell widths when sitting on a wide character. Closes #315
Owner
Author
PR Review SummaryCritical Issues (0 found)None. Important Issues (0 found)None. Suggestions (1 found)
Reviewed & Dismissed
Strengths
VerdictREADY TO MERGE The wide character rendering fix is correct. Each wide character is isolated into its own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
health.rsand trailing blank line increate.rsCloses #315
Test plan
echo "Hello 你好世界 World"in embedded terminal — CJK chars render at double width, no gaps/overlapsecho "Test 🎉🚀 Done"— emoji render at double width, "Done" properly positionedcargo test --allpassescargo clippy --all -- -D warningspasses