fix(fleet): store augmented command in session file#612
Merged
Conversation
The session file stored the base agent command before fleet flags were appended, so `kild list` showed a command missing --agent-id, --agent-name, and --team-name flags. Use the already-computed fleet_command instead so the stored command matches what actually runs. Closes #607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kild listshowed the base agent command without fleet flags (--agent-id,--agent-name,--team-name) becauseAgentProcessstored the command beforefleet_agent_flags()appended themfleet_command(which includes fleet flags when applicable) instead of the baseagent_commandwhen constructingAgentProcessTest plan
cargo fmt --checkpassescargo clippy --all -- -D warningspassescargo test --allpasses (3 pre-existing env-dependent test failures unrelated to this change)kild list --jsonshows the full command including--agent-id,--agent-name,--team-nameCloses #607