refactor: rename *Manager types to domain-role names#626
Merged
Conversation
Rename four types that used the vague `Manager` suffix to descriptive domain-role names per the Code Naming Contract: - SessionManager → DaemonSessionStore (kild-daemon) - PtyManager → PtyStore (kild-daemon) - ProjectManager → ProjectRegistry (kild-core) - TeamManager → TeamStore (kild-ui) No behavior changes — pure mechanical rename across all usages, docs, and CLAUDE.md/AGENTS.md references. Closes #520
- Rename team_manager field → team_store across all UI call sites - Rename 13 test functions test_project_manager_* → test_project_registry_* - Fix 2 doc comments still saying "project manager"
Owner
Author
PR Review SummaryCritical Issues (0 found)None. Important Issues (0 found)None. Suggestions (1 found)
Strengths
VerdictREADY TO MERGE The rename is complete and consistent. The one suggestion (missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionManager→DaemonSessionStore(kild-daemon)PtyManager→PtyStore(kild-daemon)ProjectManager→ProjectRegistry(kild-core, kild-ui)TeamManager→TeamStore(kild-ui)Pure mechanical rename — no behavior changes. Updates all usages, doc comments, and CLAUDE.md/AGENTS.md references.
Closes #520
Test plan
cargo fmt --checkpassescargo clippy --all -- -D warningspassescargo test --allpasses (2 pre-existing env-dependent failures unrelated to this change)