Skip to content

to make clang happy#205

Merged
brettviren merged 2 commits intoWireCell:masterfrom
HaiwangYu:0.24.1
Mar 29, 2023
Merged

to make clang happy#205
brettviren merged 2 commits intoWireCell:masterfrom
HaiwangYu:0.24.1

Conversation

@HaiwangYu
Copy link
Member

@HaiwangYu HaiwangYu commented Mar 29, 2023

This + rm wcsonnet and wcwires would make clang compile on gpvms.

Ref: https://www.boost.org/doc/libs/1_80_0/boost/multi_array/storage_order.hpp

Related errors:

custard

In file included from ../util/inc/WireCellUtil/Stream.h:17:
../util/inc/WireCellUtil/custard/pigenc_multiarray.hpp:64:20: error: no viable overloaded '='
            stoord = boost::fortran_storage_order();
            ~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/cvmfs/larsoft.opensciencegrid.org/products/boost/v1_75_0/Linux64bit+3.10-2.17-c7-prof/include/boost/multi_array/storage_order.hpp:79:9: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'boost::fortran_storage_order' to 'const boost::c_storage_order' for 1st argument
  class c_storage_order 
        ^
/cvmfs/larsoft.opensciencegrid.org/products/boost/v1_75_0/Linux64bit+3.10-2.17-c7-prof/include/boost/multi_array/storage_order.hpp:79:9: note: candidate function (the implicit move assignment operator) not viable: no known conversion from 'boost::fortran_storage_order' to 'boost::c_storage_order' for 1st argument

wcsonnet

apps/apps/wcsonnet.cxx.3.o: In function `std::__1::__fs::filesystem::status(std::__1::__fs::filesystem::path const&, std::__1::error_code&)':
/cvmfs/larsoft.opensciencegrid.org/products/clang/v7_0_0/Linux64bit+3.10-2.17/bin/../include/c++/v1/filesystem:1955: undefined reference to `std::__1::__fs::filesystem::__status(std::__1::__fs::filesystem::path const&, std::__1::error_code*)'
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

@HaiwangYu HaiwangYu requested a review from brettviren March 29, 2023 16:14
@HaiwangYu HaiwangYu marked this pull request as ready for review March 29, 2023 16:15
@HaiwangYu
Copy link
Member Author

HaiwangYu commented Mar 29, 2023

Did simple test to see if everything still works. Noise sim is identical, SigProc sees some fluctuations.

Screenshot 2023-03-29 at 2 09 42 PM

Screenshot 2023-03-29 at 2 05 36 PM

@brettviren brettviren merged commit d442407 into WireCell:master Mar 29, 2023
@brettviren
Copy link
Member

Thanks for your fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants