Allow to use custom configuration files#15
Merged
aarranz merged 2 commits intoWirecloud:masterfrom Nov 19, 2018
Merged
Conversation
aarranz
force-pushed
the
feature/read-only-configuration-file
branch
2 times, most recently
from
16a72e8 to
97f6021
Compare
aarranz
force-pushed
the
feature/read-only-configuration-file
branch
from
97f6021 to
4114299
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes possible to use a custom
settings.pyfile instead of configuring the image using environment variables. This is required to be able to configure any of the available settings from Django, for example.This PR add tests for this feature using a read-only volume, but the behaviour is the same when using Docker's «config». Tests has been created this way because docker-compose does not support Docker's configs.