Skip to content

Add healthcheck command in wirecloud's image#25

Merged
aarranz merged 4 commits intoWirecloud:masterfrom
samgh96:master
Mar 15, 2019
Merged

Add healthcheck command in wirecloud's image#25
aarranz merged 4 commits intoWirecloud:masterfrom
samgh96:master

Conversation

@samgh96
Copy link
Copy Markdown
Contributor

@samgh96 samgh96 commented Mar 6, 2019

This PR adds a healthcheck command in the Dockerfile.

@aarranz
Copy link
Copy Markdown
Member

aarranz commented Mar 12, 2019

Hi @samgh96,

thanks for the contribution!

Only some details, I think the default timeout is too large (30s), taking into account that the version request should take ~20 ms in a decent machine. It's true that default should cope with small installations and use a timeout with enough room for taking into account some lags. I think that something in the range of 3s would be a better option.

Also, it'd be great if you add this healthcheck configuration on the other images.

@aarranz
Copy link
Copy Markdown
Member

aarranz commented Mar 14, 2019

Can you add the healthcheck also on the dev image? Also, is it really needed the || exit 1 part of the healthcheck command?

@samgh96
Copy link
Copy Markdown
Contributor Author

samgh96 commented Mar 15, 2019

It is, HEALTHCHECK only supports exit codes of 0 and 1, and curl --fail exit code differ from 1 depending on the error.

@aarranz
Copy link
Copy Markdown
Member

aarranz commented Mar 15, 2019

Ok, thanks 😄. So the only missing piece is to add the healthcheck on the dev image and I will merge your PR.

@aarranz aarranz merged commit 0b45ccb into Wirecloud:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants