Make Docker flexible by supporting command args#28
Merged
aarranz merged 2 commits intoWirecloud:masterfrom Mar 27, 2019
jason-fox:feature/flexible-docker
Merged
Make Docker flexible by supporting command args#28aarranz merged 2 commits intoWirecloud:masterfrom jason-fox:feature/flexible-docker
aarranz merged 2 commits intoWirecloud:masterfrom
jason-fox:feature/flexible-docker
Conversation
docker build -t wirecloudx . --build-arg GITHUB_ACCOUNT=<my-account> --build-arg GITHUB_REPOSITORY=<your repo> --build-arg SOURCE_BRANCH=<your branch>
aarranz
requested changes
Mar 27, 2019
Member
aarranz
left a comment
aarranz
left a comment
There was a problem hiding this comment.
LGTM as long as you change the default value for the SOURCE_BRANCH
|
|
||
| ARG GITHUB_ACCOUNT=Wirecloud | ||
| ARG GITHUB_REPOSITORY=wirecloud | ||
| ARG SOURCE_BRANCH=master |
Member
There was a problem hiding this comment.
This develop image should use develop by default 😉.
aarranz
approved these changes
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amend the
Dockerfileso a developer can build sources based on their own repository and branchesdocker build -t wirecloudx . --build-arg GITHUB_ACCOUNT=<my-account> --build-arg GITHUB_REPOSITORY=<your repo> --build-arg SOURCE_BRANCH=<your branch>Default functionality without
build-argsis as previously.Related to Wirecloud/wirecloud#392