Notebook adds tabs before the add button#156
Merged
aarranz merged 1 commit intoWirecloud:developfrom Apr 18, 2016
Merged
Conversation
| this.tabsById[tabId] = tab; | ||
|
|
||
| var tabElement = tab.getTabElement(); | ||
| this.tabArea.appendChild(tabElement, this.new_tab_button_tabs); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request fixes #146
The problem was that notebook added a tab at the end of their tab list and the add button. Now, notebook also adds tabs at the end of their tab list but before their add button.