This repository was archived by the owner on Jan 3, 2021. It is now read-only.
Prep for v1.4.0 #33
Merged
Prep for v1.4.0 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compat for symfony 4.0, as the ProcessBuilder class is no more. Had to remove the tests as now that the Process is directly coupled into the processor, it can't be efficiently tested... To fix up in a following release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.1 (nullable types...), and some cleanup here and there. Also bumped the process component to at least 3.4, because in 4.0 the
ProcessBuilderisn't there anymore.Had to remove the only test because of the
Processmess, making it untestable without launching a process. Will maybe make a new service that gets / runs the process but meh... not really a fan. Open to suggestions,Tiny BC break too, but I don't think the impacted feature was really used (if the process failed, retry it). Use the
RetryProcessorinstead, even though won't be much help as no exceptions are thrown. Will be fixed for 2.0, if there's ever a 2.0 version.