Merged
Conversation
7d3c046 to
d621ed8
Compare
Contributor
Author
|
I'll do the whole thing about the recurring events a bit later, as it needs a bit of work (parsing, ... etc) |
Taluu
added a commit
to Taluu/CalendArt
that referenced
this pull request
Oct 15, 2014
[Google] Refactor events
Taluu
added a commit
to Taluu/CalendArt
that referenced
this pull request
Oct 15, 2014
[Google] Refactor events
Taluu
added a commit
to Taluu/CalendArt
that referenced
this pull request
Oct 15, 2014
[Google] Refactor events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling Recurring event for Google Adapter. This needs a little refacto of the google events system, in order to handle properly the recurring events... and their cancellation.
When the flag
showDeletedis set totrue, the deleted events (normal & recurring) are shown as the normal events.If it is set to
false, only cancelled instances of a recurring events, normal events, and recurrent events are shown... but the cancelled recurring events are somewhat incomplete (missing a bunch of properties which may seem important, such as the creator of the event, the start & end orginal dates, ... etc).Fucking Google, yeah.
[ ] Implement a recurring eventWill be done in another pr, as it is a huge thing by itselfThe tests should be added a little bit later when I'll have some time ahead :(