Skip to content

[Google] Refactor events#2

Merged
Taluu merged 11 commits intoWisembly:masterfrom
Taluu:recurring-events
Oct 15, 2014
Merged

[Google] Refactor events#2
Taluu merged 11 commits intoWisembly:masterfrom
Taluu:recurring-events

Conversation

@Taluu
Copy link
Copy Markdown
Contributor

@Taluu Taluu commented Oct 14, 2014

Handling Recurring event for Google Adapter. This needs a little refacto of the google events system, in order to handle properly the recurring events... and their cancellation.

When the flag showDeleted is set to true, the deleted events (normal & recurring) are shown as the normal events.

If it is set to false, only cancelled instances of a recurring events, normal events, and recurrent events are shown... but the cancelled recurring events are somewhat incomplete (missing a bunch of properties which may seem important, such as the creator of the event, the start & end orginal dates, ... etc).

Fucking Google, yeah.

  • Split Google's Event object
  • Make an abstract
  • Refactor a little bit the statics (while I'm at it)
  • Implement a normal event
  • [ ] Implement a recurring event Will be done in another pr, as it is a huge thing by itself
  • Implement a cancelled recurring event when it is truncated (phew)

The tests should be added a little bit later when I'll have some time ahead :(

@Taluu Taluu changed the title [Google] Recurring events [Google] Refactor events Oct 15, 2014
@Taluu
Copy link
Copy Markdown
Contributor Author

Taluu commented Oct 15, 2014

I'll do the whole thing about the recurring events a bit later, as it needs a bit of work (parsing, ... etc)

Taluu added a commit that referenced this pull request Oct 15, 2014
@Taluu Taluu merged commit 331efaa into Wisembly:master Oct 15, 2014
@Taluu Taluu deleted the recurring-events branch October 15, 2014 14:21
Taluu added a commit to Taluu/CalendArt that referenced this pull request Oct 15, 2014
Taluu added a commit to Taluu/CalendArt that referenced this pull request Oct 15, 2014
Taluu added a commit to Taluu/CalendArt that referenced this pull request Oct 15, 2014
Taluu added a commit that referenced this pull request Oct 15, 2014
@Taluu Taluu mentioned this pull request Oct 15, 2014
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant