ace3 milestone 8 move quest frames to UI folder#122
ace3 milestone 8 move quest frames to UI folder#122Wishmaster117 merged 7 commits intofeature/ace3-migrationfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36c1e71527
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return true | ||
| end | ||
|
|
||
| local tNonSpellStreak = tonumber(pCollectionState.nonSpellStreak) or 0 | ||
| local tNonSpellThreshold = tonumber(SPELLBOOK_END_NON_SPELL_STREAK) or 4 | ||
| if(pCollectionState.hasCollectedSpell and tNonSpellStreak >= tNonSpellThreshold) then | ||
| return true | ||
| return false |
There was a problem hiding this comment.
If the bot never sends a line that matches isSpellbookFooterLine()—for example because the delayed stats whisper is dropped or the footer text differs by locale—handleSpellbookChatLine() never leaves "SPELL" mode. From that point on it returns true for every later whisper from that unit, so Core/MultiBotHandler.lua:1545 short-circuits inventory, quest, and equipment handling until reload. The removed nonSpellStreak fallback was what prevented this dead-end.
Useful? React with 👍 / 👎.
| frame:Show() | ||
| MultiBot.TimerAfter(0.5, function() |
There was a problem hiding this comment.
When the incomplete/completed popup is already open and the user requests another bot or switches to group mode, this shows the existing frame without clearing its children first. Until the async builder runs—or indefinitely if the bot never replies—the panel still displays the previous request's quest list, which makes the new request look finished. sendCompleted has the same regression a few lines below.
Useful? React with 👍 / 👎.
1 participant
No description provided.