fix: clear rowserrcheck and sqlclosecheck; add scoped tier 4 silences#9
Merged
Conversation
Signed-off-by: Alan Wiss <alan@moldchat.com>
Signed-off-by: Alan Wiss <alan@moldchat.com>
Signed-off-by: Alan Wiss <alan@moldchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans the inherited test code: removes 27 real-bug lint findings
(
rowserrcheck,sqlclosecheck) and silences 200+ documentedfalse positives in
.golangci.ymlso future PRs see only signal.Numbers
--whole-filesmodeWhat changed
for rows.Next()loops now checkrows.Err(); rows/stmts deferreddb.Exec("drop table foo")→DROP TABLE IF EXISTSwith checked errorerrors.Is/Asinstead of==/type assertionsio/ioutilmigrated toos/io(deprecated since Go 1.19).golangci.yml: scoped silences for documented false positives(e.g.
errcheckondatabase/sqlClose,gosec G104in tests,SHA1/MD5 in
sqlite3_func_crypt.goper SQLite UserAuth contract)CONTRIBUTING.md: new Code conventions sectionValidation
-raceCaveats
//nolintremain — each with rationale (godoc Example, test discardon failure path, controlled-bounds uint→int64 in custom SQL fn)
sqlite3_opt_vtable_test.gonot touched (behind+build sqlite_vtable)