feat: avoid clustered restarts during upgrades#49
Merged
Conversation
Prevents clustered restarts when a new release is published by spreading node upgrades evenly across a 24-hour window instead of 1 hour. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When an upgrade is pending, the monitor task now sleeps for precisely the remaining rollout delay rather than waiting for the next check interval tick. This eliminates restart clustering caused by quantization to the check interval. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pre-release versions (alpha, beta, rc) should not be published to crates.io. Also removes publish-crate from the release job dependency chain so pre-release GitHub releases aren't blocked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Reduces upgrade-induced restart clustering by widening the staged rollout window and aligning sleep timing with each node’s scheduled upgrade time; also updates the release workflow to skip crates.io publishing for prereleases.
Changes:
- Increase default staged rollout window from 1 hour to 24 hours.
- When an upgrade is pending, sleep until the exact remaining rollout delay rather than the next check interval tick.
- Skip crates.io publish for prerelease tags in the GitHub Actions release workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/node.rs |
Adjusts upgrade-monitor loop to sleep until scheduled upgrade time to avoid quantization/clustering. |
src/config.rs |
Changes default staged rollout window from 1h to 24h. |
.github/workflows/release.yml |
Skips crates.io publishing for prereleases and adjusts job dependencies for release creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add backoff when rollout delay has elapsed but upgrade failed, to prevent a tight retry loop on Duration::ZERO - Wrap upgrade sleep in tokio::select! with shutdown.cancelled() so shutdown can interrupt long rollout delay sleeps - Restore publish-crate dependency on release job with conditional logic: release proceeds if publish-crate succeeds or was skipped (pre-release), but blocks if it fails (stable) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mickvandijke
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Test results
Auto-Upgrade Test Results: DEV-01
All 91 nodes (90 regular + 1 genesis) successfully upgraded from v0.7.0 to v0.7.10-rc.1.
Key findings:
🤖 Generated with Claude Code