Skip to content

fix(download): drop 5-min frontend timeout that wrongly failed completed downloads#26

Merged
mickvandijke merged 1 commit intomainfrom
fix/download-timeout
Apr 16, 2026
Merged

fix(download): drop 5-min frontend timeout that wrongly failed completed downloads#26
mickvandijke merged 1 commit intomainfrom
fix/download-timeout

Conversation

@mickvandijke
Copy link
Copy Markdown
Contributor

Summary

  • Remove the 5-minute withTimeout wrapper around the download invoke() in stores/files.ts. Large downloads can legitimately exceed 5 min; the backend has no timeout and kept streaming chunks and writing the file successfully while the UI had already flipped the row to Failed: Download timed out.
  • Matches the no-frontend-timeout pattern already used for uploads (confirm_upload / confirm_upload_merkle) — same rationale, same fix.
  • withTimeout is still used for the two wallet-approval paths, where a 5-min cap is appropriate because the user is interactively approving a tx.

Test plan

  • Download a large file whose transfer takes >5 min; confirm the row ends up Downloaded, not Failed.
  • Trigger a backend download error (e.g. bad datamap) and confirm the row still flips to Failed with the backend error message — rejection still surfaces.
  • Vitest: npx vitest run — 19 tests still pass.

🤖 Generated with Claude Code

…ted downloads as failed

Large downloads can legitimately exceed 5 minutes. The backend has no
timeout, so it kept streaming chunks and wrote the file successfully
while the UI had already flipped the row to "Failed: Download timed out".
Matches the no-timeout pattern already used for uploads.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mickvandijke mickvandijke merged commit b2158a8 into main Apr 16, 2026
4 checks passed
@mickvandijke mickvandijke deleted the fix/download-timeout branch April 16, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant