fix(download): drop 5-min frontend timeout that wrongly failed completed downloads#26
Merged
mickvandijke merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
…ted downloads as failed Large downloads can legitimately exceed 5 minutes. The backend has no timeout, so it kept streaming chunks and wrote the file successfully while the UI had already flipped the row to "Failed: Download timed out". Matches the no-timeout pattern already used for uploads. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withTimeoutwrapper around the downloadinvoke()instores/files.ts. Large downloads can legitimately exceed 5 min; the backend has no timeout and kept streaming chunks and writing the file successfully while the UI had already flipped the row to Failed: Download timed out.confirm_upload/confirm_upload_merkle) — same rationale, same fix.withTimeoutis still used for the two wallet-approval paths, where a 5-min cap is appropriate because the user is interactively approving a tx.Test plan
npx vitest run— 19 tests still pass.🤖 Generated with Claude Code