ci: override MSI wix.version for pre-release tags#27
Merged
Nic-dorman merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
Tauri's MSI bundler errors on non-numeric pre-release identifiers: ``` failed to bundle project `optional pre-release identifier in app version must be numeric-only and cannot be greater than 65535 for msi target` ``` This blocks v0.6.5-rc.1 (and any `-rc.N` / `-beta.N` / `-alpha.N` tag) from producing the Windows MSI, which in turn skips compose-latest-json (it needs: build-windows), leaving the release workflow fix from PR #23 unvalidated. The constraint is Windows-specific (MSI inherits the 4-part numeric PE resource version). Fix by computing a numeric-only `wix.version` from tauri.conf.json at build time — strip everything after `-` so `0.6.5-rc.1` becomes `0.6.5` for MSI metadata only. The app's embedded semver (what the updater compares, what `env!("CARGO_PKG_VERSION")` returns) stays untouched, so pre-release tags still behave as pre-releases everywhere except the Windows installer's Add/Remove Programs display. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
a432ad4 to
c2198a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tauri's MSI bundler rejects non-numeric pre-release identifiers, which blocked the v0.6.5-rc.1 release workflow run (mac + linux built fine, but Windows MSI errored with "optional pre-release identifier in app version must be numeric-only"). With Windows failing, `compose-latest-json` (which needs: build-windows) never ran, so PR #23's release-workflow fix was not actually validated.
Fix
Compute `wix.version` at build time by stripping the pre-release suffix from `tauri.conf.json`'s version — `0.6.5-rc.1` → `0.6.5` for MSI metadata only. Passed into `tauri build` via the same `--config` override that already sets `signCommand`.
After this merges
🤖 Generated with Claude Code