Merged
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Windows build pipeline, which is currently failing.
The make step
The make step is currently failing on Windows as the linker complains about unresolved references to
libiconvfunctions.The proposed fix is to replace the variable
LTLIBICONVinconfigure.acby hard-coded values:-liconvfor the Windows build''for the other buildsThe variable
LTLIBICONVshould actually be created by the macroAM_ICONVbut this was removed in #342. And the dependencygettextthat is needed forAM_ICONVwas removed in #350.This is probably not the cleanest fix but it keeps changes restricted to the Windows build.
The make check step
When the
makestep is fixed in the Windows pipline, themake checkcurrently fails as the next step.The problem is that the compiler is missing the flag
-D_spawnv=spawnv.This is caused by the change from #301.
The proposed change works as expected in the pipeline. And it should also work for UCRT.