MDNS and disappearing network interfaces#3
Merged
ronkorving merged 1 commit intoWizcorp:masterfrom Oct 22, 2013
achingbrain:master
Merged
MDNS and disappearing network interfaces#3ronkorving merged 1 commit intoWizcorp:masterfrom achingbrain:master
ronkorving merged 1 commit intoWizcorp:masterfrom
achingbrain:master
Conversation
|
Thanks, looks good, really appreciate you added the unit test for it too. |
ronkorving
pushed a commit
that referenced
this pull request
Oct 22, 2013
MDNS and disappearing network interfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue I describe in issue #2
When a service event is encountered, the Browser now caches the interface on which it took place. When subsequent events occur, if the call to dns_sd.if_indextoname(ifaceIdx) fails, it looks the interface name up in the cache. If the name is there it's returned, otherwise the original error is thrown.
Also includes a unit test..