This repository was archived by the owner on Sep 16, 2022. It is now read-only.
Server-side check for kernel CPU vulnerabilities.#495
Merged
vpetersson merged 5 commits intoWoTTsecurity:masterfrom Nov 6, 2019
Merged
Server-side check for kernel CPU vulnerabilities.#495vpetersson merged 5 commits intoWoTTsecurity:masterfrom
vpetersson merged 5 commits intoWoTTsecurity:masterfrom
Conversation
rptrchv
reviewed
Nov 4, 2019
rptrchv
reviewed
Nov 4, 2019
rptrchv
reviewed
Nov 4, 2019
rptrchv
reviewed
Nov 4, 2019
rptrchv
reviewed
Nov 4, 2019
rptrchv
reviewed
Nov 4, 2019
Contributor
|
@a-martynovich pls add screenshot(s) |
Contributor
Author
|
|
rptrchv
reviewed
Nov 4, 2019
backend/device_registry/api_views.py
Outdated
Contributor
There was a problem hiding this comment.
Are you sure source_name and source_version are needed here? They are not in the DebPackage model's compound unique constraint.
Contributor
Author
There was a problem hiding this comment.
How do you expect me to find the package?
Contributor
Author
There was a problem hiding this comment.
Ah I see what you mean... that name and version is enough. I guess you're right.
Contributor
There was a problem hiding this comment.
'name', 'version', 'arch' and 'os_release_codename' is enough because of:
unique_together = ['name', 'version', 'arch', 'os_release_codename']
rptrchv
reviewed
Nov 4, 2019
rptrchv
approved these changes
Nov 4, 2019
Use self.assert... in test_cpu_vulnerable(). Erase device.cpu and device.kernel_deb_package if missing in ping. Add comments to Device.cpu_vulnerable logic.
a-martynovich
force-pushed
the
482-cpu-vuln
branch
from
36618e8 to
7f4fad5
Compare
Contributor
Author
|
Added recommended action and rebased the branch. |
rptrchv
reviewed
Nov 5, 2019
| class CpuVulnerableAction(ActionPerDevice): | ||
| action_id = 12 | ||
| action_title = 'Your system is vulnerable to Meltdown and/or Spectre attacks' | ||
| action_description = 'Intel CPU sucks on %s' |
rptrchv
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#482