Bugfix: Override ENTRYPOINT in Docker image test step#162
Merged
Conversation
The test step was hanging because the Dockerfile now uses ENTRYPOINT instead of CMD, so trailing args get appended to the MCP server command rather than replacing it. Pass --entrypoint wolframscript so the sanity check actually runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Docker GitHub Actions workflow test step so it doesn’t hang when the image uses an ENTRYPOINT that starts the MCP server.
Changes:
- Override the container
ENTRYPOINTin the workflow’s “Test Docker image” step. - Run
wolframscript -code '$Version'explicitly as the container entrypoint/args to ensure the step exits after printing the version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMDtoENTRYPOINT: trailing args (wolframscript -code '\$Version') were appended to the MCP server entrypoint instead of replacing it, so the container started the server and blocked on stdin.--entrypoint wolframscripttodocker run, with-code '\$Version'as args to that entrypoint.Test plan
workflow_dispatchor a push torelease/paclet) and confirm the "Test Docker image" step completes and prints a version string instead of hanging until timeout.🤖 Generated with Claude Code