Hiding boxes did not work properly#4866
Merged
Merged
Conversation
dtdesign
approved these changes
Jun 13, 2022
BurntimeX
added a commit
that referenced
this pull request
Jun 14, 2022
BurntimeX
added a commit
that referenced
this pull request
Jun 15, 2022
The methods still contained code that became obsolete with the PR linked below. see #4866
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partly reverts #4489 which introduced the condition system for boxes. This came along with the
MultiPageConditionwhich looks like a reasonable substitute for the existing page selection, but eventually suffers from two significant deficits. First of all, the UX differs from the previous implementation that made the behavior much clearer. Second, it has a slightly different behavior by not evaluating the toggle checkbox when there is nothing selected, removing an important existing functionality.The condition system is quite powerful, but is designed around the idea of being implicitly opt-in, which does not fit out requirements. Furthermore, for compatibility the conditions have not been used at all for page, instead the selection was extracted and injected into the existing functionality. This is somewhat dangerous, because the conditions is intended to be self-contained and the internal structure is not guaranteed.
Eventually the PR #4489 is partly rolled back by introducing the previous UI element for pages again, which coincidentally plays nicely with the forum condition.
ref https://www.woltlab.com/community/thread/295815-boxen-lassen-sich-nicht-mehr-richtig-entfernen/