-
-
Notifications
You must be signed in to change notification settings - Fork 1
fix(deps): update dependency react-resizable-panels to v4.4.1 #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @WomB0ComB0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the react-resizable-panels dependency to version 4.4.0. The change is straightforward. However, based on the provided files, this dependency may be unused. I've added a comment suggesting to verify its usage and consider removing it if it's redundant, which would be more beneficial than just updating it. If it is in use, I've also highlighted a new feature in this version that could be adopted for performance improvements.
package.json
Outdated
| "react-hook-form": "7.71.0", | ||
| "react-icons": "^5.5.0", | ||
| "react-resizable-panels": "4.3.3", | ||
| "react-resizable-panels": "4.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates react-resizable-panels. Based on the provided code, this dependency doesn't appear to be used. The repository includes a scripts:check-unused script which can help confirm this. If the package is indeed unused, it would be better to remove it completely rather than updating it. This helps in reducing the overall bundle size and maintenance effort.
If the package is actively being used in a file not visible in this review, consider using the new onLayoutChanged prop introduced in this version (v4.4.0) for saving layouts. According to the release notes, it is more performant for this use case.
578beba to
b06045b
Compare
|
🎉 This PR is included in version 1.50.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR contains the following updates:
4.3.3→4.4.1Release Notes
bvaughn/react-resizable-panels (react-resizable-panels)
v4.4.1Compare Source
Panelshould treatdefaultSize={0}as collapsed on mountv4.4.0Compare Source
onLayoutChangedprop toGroup.For layout changes caused by pointer events, this method is not called until the pointer has been released. This callback should be used if you're doing something like saving a layout as it is called less frequently than the previous approach.
The
useDefaultLayouthook has also been updated to use this callback (though it will continue to support the old callback as well, with a@deprecationtag).Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.