Skip to content

Create content-error-report issue template#767

Merged
azhiya merged 2 commits intoWordPress:trunkfrom
Piyopiyo-Kitsune:patch-1
Jun 28, 2022
Merged

Create content-error-report issue template#767
azhiya merged 2 commits intoWordPress:trunkfrom
Piyopiyo-Kitsune:patch-1

Conversation

@Piyopiyo-Kitsune
Copy link
Collaborator

This is an issue template for adding Learn WordPress Content Error Reports from Help Scout to GitHub.

This is an issue template for adding Help Scout errors to GitHub.
@Piyopiyo-Kitsune Piyopiyo-Kitsune changed the title Create content-error-report Create content-error-report issue template May 29, 2022
@azhiya
Copy link
Collaborator

azhiya commented May 30, 2022

Hey @courtneyr-dev I'm assuming we can just squash and merge this.

@jonathanbossenger
Copy link
Collaborator

@azhiya I've opened PR #772 to fix the errors with the PHPCS linter, which was causing the check failure. Once those checks pass, I'll merge the fix.

@jonathanbossenger
Copy link
Collaborator

@Piyopiyo-Kitsune nice work.

Could I make one suggestion, can we update this to ask the reporter to add a link to the piece of content being reported on. This will make it a lot easier for folks working on content fixes to quickly click the relevant link to see the content with the error.

We can use HTML opening and closing tags to also include some instructions for bug reporters, which won't display in the final bug report. So for example we could include something like this in the Error Description section:

<!--
Please include the title and the URL to the content in question in the Error Description.

This can be done either using the markdown format, for example, (Creating Custom Post Types Without Code)[https://learn.wordpress.org/workshop/creating-custom-post-types-without-code/].

Alternatively, use the **Add a link** icon in the issue editor toolbar
-->

Added updates to include Jonathan's feedback and some slight tweaks.
@jonathanbossenger
Copy link
Collaborator

@azhiya @courtney-pk the PR to fix the failing tests has been merged, so it will be safe to merge this PR as well.

@azhiya
Copy link
Collaborator

azhiya commented Jun 14, 2022

@jonathanbossenger sorry I'm asking again, don't want to do make a mistake but can I go ahead and merge this.

@jonathanbossenger
Copy link
Collaborator

@azhiya sorry for the delay here (I thought I had replied). Yes, it is safe to merge. Unfortunately, because the bug was only fixed after this PR was created, it still uses the older code when running the checks. Squash and merge away! 😊

@azhiya azhiya merged commit 803e5f3 into WordPress:trunk Jun 28, 2022
@azhiya
Copy link
Collaborator

azhiya commented Jun 28, 2022

All done @Piyopiyo-Kitsune and @jonathanbossenger. That was oddly satisfying :-)

@jonathanbossenger
Copy link
Collaborator

"Feel the power!" 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants