Remove additionalProperties from the JSON response schema#18
Merged
JasonTheAdams merged 2 commits intoWordPress:trunkfrom Apr 15, 2026
Merged
Remove additionalProperties from the JSON response schema#18JasonTheAdams merged 2 commits intoWordPress:trunkfrom
additionalProperties from the JSON response schema#18JasonTheAdams merged 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #17
Ensure we remove
additionalPropertiesfrom JSON response schemasWhy?
If using the AI Client to make requests and you set a JSON response schema, OpenAI requires the
additionalPropertieskey but Google will throw an error if this exists. We already remove that key from function declarations but we also need to remove it from JSON schemasHow?
removeAdditionalPropertiesKeymethoditemskey, both top-level and nestedUse of AI Tools
Used Cursor running GPT-5.3 Codex to initially diagnose the problem (was reported on the WordPress AI plugin). Took the suggested fix, tested that and cleaned it up
Testing Instructions
Hard to test with this package alone, recommend testing with the AI plugin: