make AI settings page headers prominent#431
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #431 +/- ##
==========================================
Coverage 68.36% 68.36%
Complexity 813 813
==========================================
Files 53 53
Lines 3945 3945
==========================================
Hits 2697 2697
Misses 1248 1248
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I guess looking at this again more, I think we actually reduced the size of the titles here, which seems like maybe opposite of what we wanted? Curious for thoughts on this @juanfra @CacheMeOwside |
|
Hi @dkotter! Thanks for catching the spacing. The @wordpress/dataviews package CSS is already setting the titles to 15px, so 0.9rem actually shrank them slightly. I believe the screenshot shared by @juanfra in the issue may not be rendering the dataviews CSS. I'm happy to bump the font size to 1rem and add some spacing below the descriptions to match the screenshot. Here's what that would look like:
Let me know if this looks better. I can push the changes (font size and spacing) as part of this PR, if that's okay. |
|
Thanks for this! I can confirm the dataviews CSS in trunk is setting the 15px title. I'm testing with Gutenberg installed, and the 15px isn't there. So that's it. The thing is that probably this problem is going to land in core at some point. I believe it might be related specifically to this. So in the end we may want to fix it there. For the screenshot shared in the original issue, I adjusted the margin-bottom of |
Big caveat that I'm not a designer but this looks good to me so I'd say push those changes up to this PR |




What?
Closes #427
Increases the font size and weight of card titles on the AI settings page so they stand out clearly above the toggle labels.
Why?
On the AI settings page, the card titles and the individual toggle labels rendered at very similar sizes, leaving no clear visual step between a section title and its contents.
How?
Set the font-size to 0.9rem and font-weight to 600px for card titles in
routes/ai-home/style.scssUse of AI Tools
None
Testing Instructions
Screenshots or screencast
When I run the plugin locally, the card header labels actually render at 15px / weight 499 (inherited from the @wordpress/dataviews package). So, what I see differs from the "Current" screenshot shared by @juanfra in the issue: #427.
The proposed 0.9rem / 600 values still shows a clear visual hierarchy, so I have gone ahead with that.
Changelog Entry