chore: update all NPM deps and migrate configs#447
chore: update all NPM deps and migrate configs#447dkotter merged 11 commits intoWordPress:developfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #447 +/- ##
==========================================
Coverage 66.90% 66.90%
Complexity 907 907
==========================================
Files 59 59
Lines 4699 4699
==========================================
Hits 3144 3144
Misses 1555 1555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not sure the deal with this dependency-review workflow but both those are coming from npm ls argparse uri-js
ai@ /home/justl/work/sites/wptest/repos/ai
├─┬ @wordpress/env@11.4.0
│ ├─┬ @wp-playground/cli@3.1.20
│ │ └─┬ ajv@8.12.0
│ │ └── uri-js@4.4.1
│ └─┬ js-yaml@3.14.2
│ └── argparse@1.0.10
└─┬ @wordpress/scripts@32.0.0
├─┬ @wordpress/eslint-plugin@25.0.0
│ └─┬ eslint@9.39.4
│ ├─┬ @eslint/eslintrc@3.3.5
│ │ ├─┬ ajv@6.14.0
│ │ │ └── uri-js@4.4.1 deduped
│ │ └─┬ js-yaml@4.1.1
│ │ └── argparse@2.0.1
│ └─┬ ajv@6.14.0
│ └── uri-js@4.4.1 deduped
├─┬ eslint@10.2.1
│ └─┬ ajv@6.14.0
│ └── uri-js@4.4.1 deduped
├─┬ markdownlint-cli@0.31.1
│ ├─┬ js-yaml@4.1.1
│ │ └── argparse@2.0.1
│ └─┬ markdownlint@0.25.1
│ └─┬ markdown-it@12.3.2
│ └── argparse@2.0.1
├─┬ npm-package-json-lint@6.4.0
│ ├─┬ ajv@6.14.0
│ │ └── uri-js@4.4.1 deduped
│ └─┬ cosmiconfig@8.3.6
│ └─┬ js-yaml@4.1.1
│ └── argparse@2.0.1
├─┬ stylelint@16.26.1
│ └─┬ cosmiconfig@9.0.1
│ └─┬ js-yaml@4.1.1
│ └── argparse@2.0.1
└─┬ url-loader@4.1.1
└─┬ schema-utils@3.3.0
└─┬ ajv@6.14.0
└── uri-js@4.4.1 deduped |
397b34d to
995b166
Compare
995b166 to
d8b85c1
Compare
|
|
We would need to update https://github.com/WordPress/ai/blob/develop/.github/dependency-review-config.yml to explicitly include |
@jeffpaul I tried that in b9d7c2f but it didnt help, also the actually package is a plain old
I'm trying to debug now with some local agents, but if you have any other suggestions from experience with the 10up prior art lmk 🙇 |
|
Perhaps garycourt/uri-js#87 is causing an issue here, maybe try ALSO adding a line for the |
|
GPT-5.4 agrees with you:
And regarding why
I didn't do any further sleuthing because between GH issue you linked and the change it recommended that I applied in 8028690 , ci is now passing 🚀 |
|
Ugh, sorry @justlevine. I merged Hoping it's something minor that you can see that just needs the package lock refreshed to clear things out. |
…n to try and bring in fresh deps
|
@justlevine Okay, think I got this figured out. I had to regenerate the |
|
(Recommending we squash-merge this 😅 ) |

What?
Closes
This PR updates all NPM deps to their latest compatible versions. Specifically
@wordpress/eslint-pluginv25 and eslint v10.eslint.config.mjsand several existing issues have been remediated.@wordpress/envto v11.wp-env.jsonand.wp-env.test.jsonfiles`..wp-env.test.jsonis used for both phpunit and e2e, and negates the need of the old playwright script.@wordpress/routeand@wordpress/themeare pinned at nonconflicting versions to workaround the bug in @wordpress/build.As a result:
npm run test:e2e:env:startandnpm run test:e2e:env:stop=>npm run wp-env:test <wp-env command>Why?
This was the fastest way to detangle the bug in @wordpress/build that was introduced in #340 (comment) .
Turns out the old version of
@wordpress/scriptswasnt even reading oureslintrc.cjsfile (only *.js), and because the required fixes were all cosmetic too.Closes
How?
Use of AI Tools
npm run lint:jsresults.Testing Instructions
nvm use && npm install && npm run buildand ensure build passes successfully.npm run wp-env destroyandnpm run wp-env startand ensure the new environment builds, and can be visited at localhost:8888. Ensure the built admin screen is visible.npm run wp-env:test start -- --xdebug=coverageand ensure the test environment builds, and thennpm run test:php && npm run test:e2eand ensure tests are running on the test environment.Screenshots or screencast
Changelog Entry
@jeffpaul not sure what you want here mate. Would more broadly suggest we adopt conventional commits and start quash-merging PRs because as-is the commit-history of this repo is hell.